Patch: Fixing a Bug in Emacspeak Bookshare and Emacspeak Erc

[Parham Doustdar <parham90@xxxxxxxxxxx>]

Hi,

There are 2 bugs that I'm addressing in this patch.

The first is in the code i originally provided for the Bookshare module. Because of a misspelling, it leads to the credentials being stored in the auth-sources multiple times.

The second bug is in the Erc module. There is a call to message, which I think isn't really needed because the next lines speak the incoming message anyway.

However, the fact that this call to message is there means that certain messages cause an error about the format string passed to `message' being wrong. These messages usually contain a really long link.

With that explanation, here is the patch:

2 files changed, 2 insertions(+), 4 deletions(-)

lisp/emacspeak-bookshare.el | 2 +-

lisp/emacspeak-erc.el       | 4 +---

modified   lisp/emacspeak-bookshare.el

@@ -200,7 +200,7 @@ Returns a cons cell where the car is email, and the cdr is password."

                 :host "api.bookshare.org"

                 :port 'https

                 :create t

-                :require '(:username :secret)))))

+                :require '(:user :secret)))))

     (when found

       (let ((user (plist-get found :user))

             (secret (plist-get found :secret))

modified   lisp/emacspeak-erc.el

@@ -266,12 +266,10 @@ set the current local value to the result.")

       (set-buffer buffer)

       (when (and emacspeak-erc-room-monitor

                  emacspeak-erc-monitor-my-messages)

-        (let ((emacspeak-speak-messages nil)

-              (msg (emacspeak-erc-compute-message (ad-get-arg 0)

+        (let ((msg (emacspeak-erc-compute-message (ad-get-arg 0)

                                                   buffer)))

           (when msg

             (emacspeak-auditory-icon 'progress)

-            (message msg)

             (tts-with-punctuations dtk-punctuation-mode

                                    (dtk-speak  msg))))))))