[Emacspeak] Re: has behaviour of emacspeak-wizards-shell-toggle changed?

[T.V Raman <raman@xxxxxxxxxxx>]

prayner--- via Emacspeak <emacspeak(a)emacspeak.org> writes:


good catch -- will restore old behavior. I myself  no longre use that
command, I have replaced that with  emacspeak-wizards-shell-by-key in my
workflow. I thought shell-cd worked when I made the change, not sure
when it stopped working.  From memory made the change because shell-cd
felt more robust than stuffing strings at the shell, e.g. that can fail
if the shell is already doing something else




> I use this a bit to switch my shell buffer to the directory of the
> file from the current buffer, e.g. editing file and want to do a git
> commit.
> At some point it seems to have stopped changing the current working
> directory for the shell itself. I've looked a little and it seems the
> shell-cd function used by emacspeak-wizards-shell-toggle doesn't
> change the shell's working directory.
> Looking at the relevant commits:
> git diff  9eaa5db1cbdb fab2a5cc74452d2 emacspeak-wizards.el
>
> diff --git a/lisp/emacspeak-wizards.el b/lisp/emacspeak-wizards.el
> index 4a2a85621..572349bba 100644
> --- a/lisp/emacspeak-wizards.el
> +++ b/lisp/emacspeak-wizards.el
> @@ -735,10 +735,7 @@ If optional arg property is not supplied, read it interactively. "
>      (shell)
>      (unless (string-equal (expand-file-name dir)
>                            (expand-file-name default-directory))
> -      (goto-char (point-max))
> -      (insert (format "pushd %s" dir))
> -      (comint-send-input)
> -      (shell-process-cd dir))
> +      (shell-cd dir))
>      (emacspeak-auditory-icon 'select-object)
>      (emacspeak-speak-mode-line)))
> It looks like explicit interaction with the shell process was removed.
> Was that the intent? fwiw I prefer the old behaviour.
> cheers
> Peter

-- 

Thanks,

--Raman(I Search, I Find, I Misplace, I Research)
♈ Id: kg:/m/0285kf1  🦮