[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Search]

[Emacspeak] Re: has behaviour of emacspeak-wizards-shell-toggle changed?

Ok, could you also test manually that it's shell-cd that's changing
the directory?
Oh and thanks for pointing out emacspeak-wizards-shell-by-key. I
should reread emacspeak-wizards.el more often.
thanks again
T.V Raman writes:
>prayner--- via Emacspeak <emacspeak(a)emacspeak.org> writes:
>I just tried it C-e F11 and it does change the directory correctly.
>> I use this a bit to switch my shell buffer to the directory of the
>> file from the current buffer, e.g. editing file and want to do a git
>> commit.
>> At some point it seems to have stopped changing the current working
>> directory for the shell itself. I've looked a little and it seems the
>> shell-cd function used by emacspeak-wizards-shell-toggle doesn't
>> change the shell's working directory.
>> Looking at the relevant commits:
>> git diff  9eaa5db1cbdb fab2a5cc74452d2 emacspeak-wizards.el
>> diff --git a/lisp/emacspeak-wizards.el b/lisp/emacspeak-wizards.el
>> index 4a2a85621..572349bba 100644
>> --- a/lisp/emacspeak-wizards.el
>> +++ b/lisp/emacspeak-wizards.el
>> @@ -735,10 +735,7 @@ If optional arg property is not supplied, read it interactively. "
>>      (shell)
>>      (unless (string-equal (expand-file-name dir)
>>                            (expand-file-name default-directory))
>> -      (goto-char (point-max))
>> -      (insert (format "pushd %s" dir))
>> -      (comint-send-input)
>> -      (shell-process-cd dir))
>> +      (shell-cd dir))
>>      (emacspeak-auditory-icon 'select-object)
>>      (emacspeak-speak-mode-line)))
>> It looks like explicit interaction with the shell process was removed.
>> Was that the intent? fwiw I prefer the old behaviour.
>> cheers
>> Peter
>--Raman(I Search, I Find, I Misplace, I Research)
>♉ Id: kg:/m/0285kf1  🦮

Peter Rayner (he/him), Level 1, 187 Grattan St.
Academic Lead - Climate & Energy College <https://www.climatecollege.unimelb.edu.au>
mobile +61 402 752 379, skype: petermorag 
zoom id 4431343191, join at  <https://unimelb.zoom.us/j/4431343191?pwd=a1E5Z3JEOTRVQUJsaVdRbVUvR1QyZz09>
mail-to: prayner(a)unimelb.edu.au TWITTER: @raynerstrings
I acknowledge the Traditional Custodians of the land on which I work, the Wurundjeri people of the Kulin nation, and pay my respect to their Elders, past and present
I am sending this email when convenient for me, please only respond when convenient for you

|May 1995 - Last Year|Current Year|

If you have questions about this archive or had problems using it, please contact us.

Contact Info Page