Gesendet: Mittwoch, 16. November 2022 um 00:34 Uhr
Von: "Tim Cross via Emacspeak" <emacspeak@xxxxxxxxxxx>
An: "Till Fabian Blesik" <Till.Blesik@xxxxxxxxxxx>
Cc: emacspeak@xxxxxxxxxxx
Betreff: [Emacspeak] Re: New Vertico Patch
What I suspect is going on here is due to differences in vertico
versions. The changes which prompted Hunter's original patch are for the
latest version of vertico. I'm not sure if that version has yet been
pushed to ELPA. However, for users, like me, who are using
straight.el and not package.el to install packages, they will have the
latest git version of vertico.
Upshot is, the patch may not be needed for most users YET. However, once
the current git version of vertico is pushed to ELPA, then this patch
(or something very similar) will be needed.
It is because I'm using straight.el and therefore 'in front' of most
'standard' package.el users that I did not submit my patch as I was
concerned it would break too much for those using a more standard
configuration.
I guess the robust way of doing the patch would be to try and make it
version dependent. However, as the emacspeak-vertico.el is dependent on
'internal' variables/functions which are not guaranteed to remain stable
(unlike the public API parts), I suspect other patches will be needed
and once we start adding version checks for all these patches, things
will become unmanageable.
Till Fabian Blesik via Emacspeak <emacspeak@xxxxxxxxxxx> writes:
> Hi both,
>
> I just pulled the changes and now constantly get the following error when I try to move in a selection list, for example to select a
> file or a project:
> Error in post-command-hook (vertico--exhibit): (void-function vertico--allow-prompt)
> As a result, the selected result is neither spoken nor does the visual indicator move.
> However, something is happening because I can see that the buffer content changes when I run consult-buffer and press C-n or
> C-p.
>
> Reverting by 1 commit back to 53af101d6 solves the issue.
>
> BR,
> Till
>
>
> Gesendet: Dienstag, 15. November 2022 um 16:08 Uhr
> Von: "T.V Raman via Emacspeak" <emacspeak@xxxxxxxxxxx>
> An: "Hunter Jozwiak via Emacspeak" <emacspeak@xxxxxxxxxxx>
> Cc: "Hunter Jozwiak" <hunter.t.joz@xxxxxxxxxxx>, emacspeak@xxxxxxxxxxx
> Betreff: [Emacspeak] Re: New Vertico Patch
> This patch failed to apply and the code looks wrong; specifically
> vertico--allow-prompt is a function -- not a variable.
>
> I've applied a hand-generated fix but I dont use vertico so someone will
> need to test it -- if I dont hear back in a week, I'll revert the fix I
> checked in.
_______________________________________________
Emacspeak mailing list -- emacspeak@xxxxxxxxxxx
To unsubscribe send an email to emacspeak-leave@xxxxxxxxxxx