[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacspeak] Emacspeak no longer working with Magit and Helm?



Hi all,
Just wanted to share my findings.
Apparently, the commit 719ac234f94f3d04fc0ef914757e78b3822220db was a conversion from the old way of specifying key bindings to new ones. However, there are a couple of issues in the conversion and that causes an error when emacspeak-erc.el gets evaluated. Here is a patch to fix it:
1 file changed, 2 insertions(+), 2 deletions(-)
lisp/emacspeak-erc.el | 4 ++--

modified   lisp/emacspeak-erc.el
@@ -292,8 +292,8 @@ set the current local value to the result.")
 (when (and (boundp 'erc-mode-map)
            (keymapp erc-mode-map))
   (define-key erc-mode-map
-              (kbd "C-c ") 'emacspeak-erc-toggle-speak-all-participants)
-  (define-key erc-mode-map (kbd "C-cm")
+              (kbd "C-c SPC") 'emacspeak-erc-toggle-speak-all-participants)
+  (define-key erc-mode-map (kbd "C-c m")
               'emacspeak-erc-toggle-my-monitor)
   (define-key erc-mode-map (kbd "C-c C-m") 'emacspeak-erc-toggle-room-monitor)
   (define-key erc-mode-map (kbd "C-c C-a")



On 12 Nov 2024, at 14:30, Parham Doustdar <parham90@xxxxxxxxx> wrote:

Hi,
I’ve been debugging this further, and I’m noticing two things.
One, my understanding of how Emacspeak gets initialised, how the autoload work, and why we need things like loaders is very lacking. So if anyone can chime in with an explanation or any resources that’d be great.
Second, if I manually open emacspeak-magit.el and emacspeak-helm.el and do `M-x eval-buffer <RET>’ things start working again. I can confirm that Emacspeak functions were not added to the relevant hook in Helm, for example.
For anyone wondering what these packages do, magit is an interface to git, and helm is a completion package. You can get them through alpa like any other package.
Thanks.

On 12 Nov 2024, at 14:16, D.J.J. Ring, Jr. <n1ea@xxxxxxxx> wrote:

What are Magit and Helm, what do they do, and where can you get them?

Thanks,
David


On Tue, Nov 12, 2024, 8:10 AM Parham Doustdar <emacspeak@xxxxxxxxxxxxx> wrote:
Hi all,
Has anyone else noticed that Magit and Helm don’t work well with Emacspeak after their latest updates? I’m wondering if something in my configuration might be causing this, even though I didn’t really change anything.
Thanks!Emacspeak discussion list -- emacspeak@xxxxxxxxxxxxx
To unsubscribe send email to:
emacspeak-request@xxxxxxxxxxxxx with a subject of: unsubscribe




|Full archive May 1995 - present by Year|Search the archive|


If you have questions about this archive or had problems using it, please contact us.

Contact Info Page