[patch] emacspeak-w3m.el and problems (was: new patches)

["T. V. Raman" <raman@xxxxxxxxxxx>]

many of these errors are because things that shouldn't be macros
are defined as macros in w3m --- see my earlier message about
cleaning up w3m itself and changing those to defsubst where appropriate.

>>>>> "Robert" == Robert D Crawford <rdc1x@xxxxxxxxxxx> writes:
    Robert> "T. V. Raman" <raman@xxxxxxxxxxx> writes:
    >> your patches are checked in.
    Robert> 
    Robert> Thanks.
    Robert> 
    >> Unrelated to these patches: emacspeak-w3m.el needs a bunch
    >> of cleanup --- could you fix the missing declaration of
    >> globals -- specifically w3m-current-url in many of the
    >> google commands?
    Robert> 
    Robert> Here is a patch that I think catches all the
    Robert> undeclared global variables.
    Robert> 
    Robert> I have found some other issues with the code.  A few
    Robert> of these I have known about for some time but they
    Robert> weren't show stoppers so they went to the back of the
    Robert> queue.
    Robert> 
    Robert> this shows up when tabbing to a submit button.  It
    Robert> only stops things when debug-on-error is on,
    Robert> otherwise it just doesn't speak the button text.
    Robert> 
    Robert> Debugger entered--Lisp error:
    Robert> (wrong-number-of-arguments #[(form &optional name
    Robert> value)
    Robert> ("/home/rdc/share/emacs/site-lisp/emacspeak/lisp/emacspeak-w3m.elc"
    Robert> . 7082) nil 9
    Robert> ("/home/rdc/share/emacs/site-lisp/emacspeak/lisp/emacspeak-w3m.elc"
    Robert> . 6981)] 4)
    Robert> emacspeak-w3m-speak-form-submit([w3m-form-object get
    Robert> "http://www.google.com/search" nil
    Robert> application/x-www-form-urlencoded (1 (:value ...) 2
    Robert> (:value ...) 3 (:value ...) 4 (:value ...) 5 (:value
    Robert> ...))] "btnG" "Google Search" w3m-form-new-session)
    Robert> apply(emacspeak-w3m-speak-form-submit
    Robert> ([w3m-form-object get "http://www.google.com/search"
    Robert> nil application/x-www-form-urlencoded (1 ... 2 ... 3
    Robert> ... 4 ... 5 ...)] "btnG" "Google Search"
    Robert> w3m-form-new-session))
    Robert> emacspeak-w3m-speak-this-anchor() w3m-next-anchor(1)
    Robert> call-interactively(w3m-next-anchor)
    Robert> 
    Robert> 
    Robert> The transcode functions both work with no args but
    Robert> the transcode-current-url gives an error.  This seems
    Robert> to be an error in the url being passed.  I included
    Robert> this for completeness, as I think I can track this
    Robert> down but thought I would mention it when sending the
    Robert> patch.
    Robert> 
    Robert> I do not have this function on my system.  (defadvice
    Robert> w3m-wget (after emacspeak pre act comp)
    Robert> 
    Robert> Since I have toggled debug-on-error I have seen a few
    Robert> other errors, but they will have to wait until my
    Robert> next mail.
    Robert> 
    Robert> Thanks, rdc
    Robert> 
    Robert> 
    Robert> 
    Robert> 
    Robert> 
    Robert> 
    Robert> -- Robert D. Crawford rdc1x@xxxxxxxxxxx
    Robert> 
    Robert> I'm totally DESPONDENT over the LIBYAN situation and
    Robert> the price of CHICKEN ...

-- 
Best Regards,
--raman

      
Email:  raman@xxxxxxxxxxx
WWW:    http://emacspeak.sf.net/raman/
AIM:    emacspeak       GTalk: tv.raman.tv@xxxxxxxxxxx
PGP:    http://emacspeak.sf.net/raman/raman-almaden.asc
Google: tv+raman 
IRC:    irc://irc.freenode.net/#emacs

-----------------------------------------------------------------------------
To unsubscribe from the emacspeak list or change your address on the
emacspeak list send mail to "emacspeak-request@xxxxxxxxxxx" with a
subject of "unsubscribe" or "help"