Re: [patch] espeak server should not install .so file in /usr/share/emacs

[William Hubbs <w.d.hubbs@xxxxxxxxxxx>]

Hello again Raman,

The reason I suggest /usr/lib/emacspeak for the .so file comes from the
fhs's definition of what should go in /usr/share [1], which gentoo linux
attempts to follow most of the time.
The .so file does not fit this definition since it is not architecture
independent.  It seems to better fit the definition of /usr/lib [2].  I
put it in /usr/lib/emacspeak since there will be other .so files for
other speech servers as well, and I thought they should be in one place.

  It seems to better fit the definition of /usr/lib [2].  Also, I put it
  in an emacspeak sub directory because there are several of these .so files for
  other servers.

Take a look at the patch attached to this reply and let me know what you
think about it.  I think this modification of the tcl script would work
for both packagers and users because it checks the place in the current
directory then the path in /usr/lib/emacspeak.

William

[1]
http://www.pathname.com/fhs/pub/fhs-2.3.html#USRSHAREARCHITECTUREINDEPENDENTDATA

[2]
http://www.pathname.com/fhs/pub/fhs-2.3.html#USRLIBLIBRARIESFORPROGRAMMINGANDPA

On Mon, Jan 04, 2010 at 08:30:19AM -0800, T.V. Raman wrote:
> I  am not yet comfortable in putting files from emacspeak across
> diferent parts of the file system -- it   makes cleaning up after
> a mess. I dont like /usr/lib/emacspeak for that reason; I also
> dislike the /etc/ hacks out there in some of the de debian packages.
> -- 
> 
> -- 
> 
> 
> On 1/2/10, William Hubbs <w.d.hubbs@xxxxxxxxxxx> wrote:
> > Hello Raman,
> >
> > because of the way the makefiles are set up now for emacspeak, it is
> > possible for us on gentoo to automatically build the tclespeak.so module
> > if the user requests that when they install emacspeak.  However, the
> > default location where the .so is installed is not correct according to
> > bug http://bugs.gentoo.org/298012.
> >
> > The same issue will also apply to the dtk-soft and outloud servers.
> >
> > I have patches for the dtk-soft and espeak servers below.  But I haven't
> > written one for the outloud server yet since it uses the $tclTTS
> > variable not only for the .so path, but for the path to eci.ini as well.
> >
> > These patches install the .so files in /usr/lib/emacspeak.  What do you
> > think about putting them there?  Also, where should we put eci.ini?
> > Maybe /etc/emacspeak?
> >
> > William
> >
> >
> 
> -----------------------------------------------------------------------------
> To unsubscribe from the emacspeak list or change your address on the
> emacspeak list send mail to "emacspeak-request@xxxxxxxxxxx" with a
> subject of "unsubscribe" or "help".
> 

Index: servers/linux-espeak/Makefile
===================================================================
--- servers/linux-espeak/Makefile	(revision 6430)
+++ servers/linux-espeak/Makefile	(working copy)
@@ -2,8 +2,7 @@
 
 INSTALL = install
 PREFIX = /usr
-LIBPARENTDIR = ${PREFIX}/share/emacs/site-lisp
-LIBDIR =$(LIBPARENTDIR)/emacspeak/servers/linux-espeak
+LIBDIR = ${PREFIX}/lib
 TCL_VERSION = 8.4
 TCL_INCLUDE= /usr/include/tcl$(TCL_VERSION)
 CXXFLAGS+= -g    -O2 -fPIC  -DPIC  -pedantic -ansi -Wall -Wno-long-long -I$(TCL_INCLUDE)
@@ -21,6 +20,6 @@
 	rm -f *.so *.o
 
 install: $(TTS)
-	$(INSTALL) -d $(DESTDIR)$(LIBDIR)
-	$(INSTALL) $< $(DESTDIR)$(LIBDIR)
+	$(INSTALL) -d $(DESTDIR)$(LIBDIR)/emacspeak
+	$(INSTALL) $< $(DESTDIR)$(LIBDIR)/emacspeak
 
Index: servers/espeak
===================================================================
--- servers/espeak	(revision 6430)
+++ servers/espeak	(working copy)
@@ -511,7 +511,11 @@
 }
 set servers [file dirname $argv0]
 set tclTTS $servers/linux-espeak
-load $tclTTS/tclespeak.so
+if {[file exists $tclTTS/tclespeak.so]} {
+    load $tclTTS/tclespeak.so
+} else {
+    load /usr/lib/emacspeak/tclespeak.so
+}
 if {[file exists /proc/asound]} {
     set tts(play) /usr/bin/aplay
 }

Attachment: pgp0RsK42siDo.pgp
Description: PGP signature