Patch: update how emacspeak-play-emacspeak-startup-icon is initialized

[Parham Doustdar <parham90@xxxxxxxxxxx>]

Hi,

Today a user installing Emacspeak on a fresh MacOS ran into a confusing issue. When helping him debug it, I noticed that Emacspeak uses the executable-find to set the value of emacspeak-play-emacspeak-startup-icon, and later completely disregards it by doing it again. Also, the way it is right now it causes an error because if mplayer isn't installed (and it is not installed by default on MacOS), this causes a cryptic error about nil not being a string.

Here is a tiny patch to make the variable behave as it should, and also removing the unnecessary call to executable-find:

1 file changed, 1 insertion(+), 1 deletion(-)
lisp/emacspeak.el | 2 +-

modified   lisp/emacspeak.el
@@ -433,7 +433,7 @@ caps."
 ;;{{{ Emacspeak:
 
 (defcustom emacspeak-play-emacspeak-startup-icon
-  (executable-find emacspeak-m-player-program)
+  t
   "If set to T, emacspeak plays its icon as it launches."
   :type 'boolean
   :group 'emacspeak)