Re: patch for emacspeak-gnus.el

["Robert D. Crawford" <rdc1x@xxxxxxxxxxx>]

"T. V. Raman" <raman@xxxxxxxxxxx> writes:

> I've applied the patch and re-arranged the code to ensure that
> defsubsts occur before they are used.

Thanks for accepting my patches.  I feel bad that you are having to make
changes before they are ready to go.  I have a question as to how I am
doing things so that we can avoid this in the future.

> in general, before submitting a patch -- ensure that 8all* byte
> compiler warnings are eliminated.

I thought I had done this.  Let me give you the steps that I took so
that you can tell me where I mis-stepped.  

1.  All new code goes into my .emacs file.  All code that is changed is
    changed in the emacspeak-gnus.el file and I make a note so that I
    remember what I changed.

2.  I do a cvs update to make sure that I have the latest version.

3.  I make a copy of the emacspeak-gnus.el file with an orig extension.  

4.  In the .el file I make the edits and add my code in the section that
    appears to be correct.

5.  I then make a diff file and apply the patch to the orig file so that
    I can make sure that no errors come up in the patch.

6.  I run the make config, and look for an error at the end of the
    output.  If I see the message that says something like "now run make
    emacspeak" I run make emacspeak, again looking for errors at the end
    of the output.  I think this might be where I am going wrong.  Does
    the make emacspeak command not choke on errors like other make
    commands?

7.  Now I exit emacs and from the console I run a script that does the
    make install and builds the atcleci files, moves the eci.ini file
    that I have edited to the correct location, etc.

8.  If emacspeak runs after this, I send the patchfile.

As I said, I feel bad that you have to make changes before my patches
will apply and build cleanly.  This is work that I should be doing, it
is just that I thought I was doing it correctly.  If you can tell me
where I am going wrong, I will do my damnedest to make sure that your
job is made easier, not more difficult, in the future.  

> This is a good way to lit your code.

Lit?  I do not understand.

Thanks for all your help,

rdc

-- 
|=|=|=|=|=|=|=|=|=|=|=|=|=|=|=|=|=|=|=|=|=|=|=|=|=|=|=|=|=|=|=|=|=|=|=|=|=|
Robert D. Crawford                                      rdc1x@xxxxxxxxxxx

"You have been in Afghanistan, I perceive."
		-- Sir Arthur Conan Doyle, "A Study in Scarlet"
|=|=|=|=|=|=|=|=|=|=|=|=|=|=|=|=|=|=|=|=|=|=|=|=|=|=|=|=|=|=|=|=|=|=|=|=|=|

-----------------------------------------------------------------------------
To unsubscribe from the emacspeak list or change your address on the
emacspeak list send mail to "emacspeak-request@xxxxxxxxxxx" with a
subject of "unsubscribe" or "help"