Subject: Emacspeak discussion list
List archive
Re: [Emacspeak] [tvraman/emacspeak] Guard against nil nil compare between pactl and play-program (PR #113)
Chronological Thread
- From: "T.V Raman" <raman AT google.com>
- To: Robert Melton <notifications AT github.com>
- Cc: emacspeak AT emacspeak.net, tvraman/emacspeak <emacspeak AT noreply.github.com>, tvraman/emacspeak <reply+AAD3P3WUIINKDIPNB32XGSGDZZ6H3EVBNHHH4U7244 AT reply.github.com>, Subscribed <subscribed AT noreply.github.com>,emacspeak AT emacspeak.net
- Subject: Re: [Emacspeak] [tvraman/emacspeak] Guard against nil nil compare between pactl and play-program (PR #113)
- Date: Mon, 05 Feb 2024 14:36:18 -0800
(For the future: we need to come up with a scheme for design discussions
so they make it to the emacspeak mail list)
Also, writing a PR, especially small ones with no overarching design
will lead to the codebase becoming incomprehensible, e.g. "I dont know
why this guard is here but I'm too scared to delete it"
I believe you dont neeed that because:
1. emacspeak-play-program is nil:
2. See that defcustom: in that case, we select emacspeak-serve-auditory-icon
3. emacspeak-pactl is nil: this is linux' pipewire player.
4. If it is nil, hen pactl is not installed --and play-program defaults
to play from sox
5. We also used to rely on aplay from alsa
6. But at this point I'm dropping that as we move all icons to .ogg files.
7. aplay cannot play ogg, sox-play can.
8. Dropping mp3 so we dont depend on mplayer; sox-play can handle mp3 if
built with mp3 support, but not all distros bundle sox with mp3
support compiled in.
9.
<cite>
When emacspeak-play-program is nil and emacspeak-pactl is also nil it
will incorrectly return true in 3 places in emacspeak-sounds.el so I
added a simple when
emacspeak-play-program guard around those three places.
</cite>
--
- Re: [Emacspeak] [tvraman/emacspeak] Guard against nil nil compare between pactl and play-program (PR #113), T.V Raman, 02/05/2024
Archive powered by MHonArc 2.6.19+.