Re: [patch] espeak server should not install .so file in /usr/share/emacs

[William Hubbs <w.d.hubbs@xxxxxxxxxxx>]

Hello Raman,

On Mon, Jan 25, 2010 at 03:17:08PM -0800, T.V. Raman wrote:
> In this specific case of where the compiled tts libs for loading
> into TCL  go when installed, I remain unconvinced; and also, note
> that the patch that would be needed goes beyond the Makefile int
> he various synth directories, one would have to update the tcl
> scripts appropraitely to look for the .so library in the
> installed location.

I understand that, and the second patch I sent you did that.  Did you
get that patch?  It updated the tcl script so that it first looked where
it currently looks then it looked in /usr/lib/emacspeak only if that
failed.  I'm attaching the second patch I sent again for reference.

> For now, if you continue to believe that
> doing is the right thing, then I suggest you apply this patch
> downstream from the emacspeak svn repos, and let's revisit the
> issue based on how things work out.

If the second patch I sent you were applied, the only thing that I
would suggest to be done differently is have a way to pass a path
to the tcl script, so that "/usr/lib/emacspeak" is not hard coded as the
second option, but there is some way to set it, preferably at build time.

What do you think?

William

Index: servers/linux-espeak/Makefile
===================================================================
--- servers/linux-espeak/Makefile	(revision 6430)
+++ servers/linux-espeak/Makefile	(working copy)
@@ -2,8 +2,7 @@
 
 INSTALL = install
 PREFIX = /usr
-LIBPARENTDIR = ${PREFIX}/share/emacs/site-lisp
-LIBDIR =$(LIBPARENTDIR)/emacspeak/servers/linux-espeak
+LIBDIR = ${PREFIX}/lib
 TCL_VERSION = 8.4
 TCL_INCLUDE= /usr/include/tcl$(TCL_VERSION)
 CXXFLAGS+= -g    -O2 -fPIC  -DPIC  -pedantic -ansi -Wall -Wno-long-long -I$(TCL_INCLUDE)
@@ -21,6 +20,6 @@
 	rm -f *.so *.o
 
 install: $(TTS)
-	$(INSTALL) -d $(DESTDIR)$(LIBDIR)
-	$(INSTALL) $< $(DESTDIR)$(LIBDIR)
+	$(INSTALL) -d $(DESTDIR)$(LIBDIR)/emacspeak
+	$(INSTALL) $< $(DESTDIR)$(LIBDIR)/emacspeak
 
Index: servers/espeak
===================================================================
--- servers/espeak	(revision 6430)
+++ servers/espeak	(working copy)
@@ -511,7 +511,11 @@
 }
 set servers [file dirname $argv0]
 set tclTTS $servers/linux-espeak
-load $tclTTS/tclespeak.so
+if {[file exists $tclTTS/tclespeak.so]} {
+    load $tclTTS/tclespeak.so
+} else {
+    load /usr/lib/emacspeak/tclespeak.so
+}
 if {[file exists /proc/asound]} {
     set tts(play) /usr/bin/aplay
 }