Emacspeak discussion list

[Parham Doustdar <parham90 AT gmail.com>]

Ah, makes sense, thank you!
Yes, so, the typo makes the command for changing themes fail silently, and 
that's because "3d" is misspelled as "3c". Fixing the typo makes the command 
behave correctly again.
Sent from my iPhone

> On Feb 22, 2024, at 20:57, T.V Raman <raman AT google.com> wrote:
> 
> Robert Melton <lists AT robertmelton.com> writes:
> 
> precisely
>> For myself, not speaking for Raman, it wasn't clear what you changed
>> on those lines, and required me to diff the lines.  I would have loved
>> a comment like "ogg-3d had a typo and was listed as ogg-3c, this patch
>> fixes that".
>> 
>>>> On Feb 22, 2024, at 14:52, Parham Doustdar (via emacspeak Mailing List) 
>>>> <emacspeak AT emacspeak.net> wrote:
>>> 
>>> Hi Raman,
>>> Not sure I follow. Are you saying my explanation wasn't sufficient,
>>> or is it that you missed the beginning of my email? If the former,
>>> can you be more specific on what "good" would've looked like so I
>>> can do better next time? If the latter, here is the beginning 2
>>> lines of my email:
>>> "Hi,
>>> Just noticed this typo which prevents changing sound themes from working. 
>>> Patch is below:"
>>> Thanks!
>>> Sent from my iPhone
>>> 
>>>> On Feb 22, 2024, at 20:18, T.V Raman <raman AT google.com> wrote:
>>>> 
>>>> Please do not send bare patches without details on what it is fixing:
>>>> 
>>>> 1. I'm not going to do a diff for a one character change
>>>> 2. I'm not going to blindly apply patches sent to the list.
>>>> --
>>> Emacspeak discussion list -- emacspeak AT emacspeak.net
>>> To unsubscribe send email to:
>>> emacspeak-request AT emacspeak.net with a subject of: unsubscribe
>> 
>> --
>> Robert "robertmeta" Melton
>> lists AT robertmelton.com
>> 
> 
> --