Emacspeak discussion list

[Jerry Sievers <gsievers19 AT comcast.net>]

Greetings Raman, et al;

Hopeing to be missing something simple here, but below is a patch that I
bisected out from between emacspeak versions 57 and58, where on my setup
at least, output from things like C-x l count-lines-page, and perhaps
lots of things that invoke the message function, don't get spoken.

Below marked with ## is the patch.

Some TLDR first is, that after a couple years of happiness running
emacspeak 56 on another Mac, I purchased a shiny new Macbook Air, 15
inch, M3, 16GB RAM.  sweet!

I grabbed the latest sources and built, at first using the Python
server, then tested Mr. RobertMeta's snappy swiftmac driver.

I had noticed right away that regardless of swiftmac or the Python
driver that $some things weren't speaking but lateer realized that
apparently many things, that invoke the message function didn't speak.

I went on to roll back to v56 OK, v57 OK using the Python driver, then
v58 at which point some essential things went silent.

I'm aware of the newer side-channel notification work but enabling that
for the swiftmac driver made no difference, and with the log-swiftmac
wrapper, confirmed that some test stuff I ran using the message function
never made it to the driver via regular or notification instance.

The bisect gave me this patch as first regression case from between v57
and v58.

## commit 14d5e4f59
Author: T.V Raman <tv.raman.tv AT gmail.com>
Date:   Mon Mar 13 09:20:26 2023 -0700

    protect against echo-keystrokes being 0

diff --git a/lisp/emacspeak-advice.el b/lisp/emacspeak-advice.el
index f53e4f43d..67830d7a1 100644
--- a/lisp/emacspeak-advice.el
+++ b/lisp/emacspeak-advice.el
@@ -775,8 +775,10 @@ When on a close delimiter, speak matching delimiter 
after a small delay. "
               (not (zerop (length m)))
               (not (string= m emacspeak-last-message))
               (not (string-match ems--message-filter-pattern m))
-              (<  (/ echo-keystrokes 20)
-               (float-time (time-subtract (current-time) 
ems--lazy-msg-time))))
+              (and
+               (not (zerop echo-keystrokes))
+               (<  (/ echo-keystrokes 20)
+                   (float-time (time-subtract (current-time) 
ems--lazy-msg-time)))))
            (setq ems--lazy-msg-time (current-time)
                  emacspeak-last-message  m)
 ;;; so we really need to speak it


Please enlighten me or advise on how I can further research this.

Thanks!